Remove undeed header file. #6158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebtenzzre
reviewed
Mar 19, 2024
There was a problem hiding this comment.
I know ggerganov hates when I make comments like this, but...
This file is missing #include <stdexcept> for std::invalid_argument. And it also has no reason to include <fcntl.h>, <ios>, or "llama.h".
|
@phymbert Do you know why the server tests are failing? It's obviously not related to this PR, but I don't really understand the log. |
It looks something made the windows build generating new tokens, need to fix the regex to include Anna for example |
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 1, 2024
hodlen
pushed a commit
to hodlen/llama.cpp
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This include breaks the build on MSVC, and removing it fixes the issue. Tested build on Linux successfully as well.
EDIT: This is a regression from PR #6135